Classify FIXMEs - 7 #4235
Merged
Classify FIXMEs - 7 #4235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @tgross35 (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
lvllvl
force-pushed
the
4117-part-7
branch
3 times, most recently
from
afbf998 to
71d6ea8
Compare
tgross35
requested changes
Jan 10, 2025
libc-test/build.rs
Outdated
| @@ -3681,7 +3681,7 @@ fn test_linux(target: &str) { | |||
| return true; | |||
| } | |||
| match ty { | |||
| // FIXME: `sighandler_t` type is incorrect, see: | |||
| // FIXME(linux): `sighandler_t` type is incorrect, see: | |||
There was a problem hiding this comment.
To go with my comment above, this can be FIXME(sighandler)
tgross35
added
the
stable-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Responding to #4117, added labels to all FIXMEs in repo. Breaking this up into multiple PRs for review.
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI